fix: Add WITH ORDER display in information_schema.views #18282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Oct 26, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @gene-bordegaray !
Can you please add some tests, ideally in sqllogicteset format?
Here are the instructions: https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest
Ideally you should be able to extend https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest/test_files/information_schema.slt
cc @NGA-TRAN as the filer of the request
Contributor
Author
2010YOUY01
reviewed
Oct 27, 2025
NGA-TRAN
approved these changes
Oct 27, 2025
Contributor
NGA-TRAN
left a comment
NGA-TRAN
left a comment
There was a problem hiding this comment.
Looks great. You may want to add one more test suggested by @2010YOUY01 . Thanks @gene-bordegaray
alamb
approved these changes
Oct 28, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @gene-bordegaray @NGA-TRAN and @2010YOUY01
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#18267. /cc @NGA-TRAN ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> The `information_schema.views` does not have display `WITH ORDER` for the definition of a table. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Added condition for writing `WITH ORDER` for CreateExternalTable. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Did not add tests for this functionality as not other display functionality has tests and seems like a separate PR would be appropriate if this is needed. This was tested manually with: In `datafusion-cli` ``` -- Not sorted CREATE EXTERNAL TABLE dimension_csv STORED AS CSV LOCATION '/path/to/the/attached/dimension_1.csv' OPTIONS ('format.has_header' 'true'); -- Sorted CREATE EXTERNAL TABLE dimension_csv_sorted STORED AS CSV WITH ORDER (env, service, host) LOCATION '/path/to/the/attached/dimension_1.csv' OPTIONS ('format.has_header' 'true'); ``` Then running: ``` select * from information_schema.views; ``` With link to data: [dimension_1.csv](https://github.com/user-attachments/files/23124138/dimension_1.csv) ## Are there any user-facing changes? Yes, improves the information_schema.views display to include `WITH ORDER` <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
codetyri0n
pushed a commit
to codetyri0n/datafusion
that referenced
this pull request
Nov 11, 2025
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#18267. /cc @NGA-TRAN ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> The `information_schema.views` does not have display `WITH ORDER` for the definition of a table. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Added condition for writing `WITH ORDER` for CreateExternalTable. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Did not add tests for this functionality as not other display functionality has tests and seems like a separate PR would be appropriate if this is needed. This was tested manually with: In `datafusion-cli` ``` -- Not sorted CREATE EXTERNAL TABLE dimension_csv STORED AS CSV LOCATION '/path/to/the/attached/dimension_1.csv' OPTIONS ('format.has_header' 'true'); -- Sorted CREATE EXTERNAL TABLE dimension_csv_sorted STORED AS CSV WITH ORDER (env, service, host) LOCATION '/path/to/the/attached/dimension_1.csv' OPTIONS ('format.has_header' 'true'); ``` Then running: ``` select * from information_schema.views; ``` With link to data: [dimension_1.csv](https://github.com/user-attachments/files/23124138/dimension_1.csv) ## Are there any user-facing changes? Yes, improves the information_schema.views display to include `WITH ORDER` <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
/cc @NGA-TRAN
Rationale for this change
The
information_schema.viewsdoes not have displayWITH ORDERfor the definition of a table.What changes are included in this PR?
Added condition for writing
WITH ORDERfor CreateExternalTable.Are these changes tested?
Did not add tests for this functionality as not other display functionality has tests and seems like a separate PR would be appropriate if this is needed.
This was tested manually with:
In
datafusion-cliThen running:
With link to data: dimension_1.csv
Are there any user-facing changes?
Yes, improves the information_schema.views display to include
WITH ORDER