Add entry to upgrade guide for #18231 #18269
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by Claude
github-actions
bot
added
the
documentation
Jefffrey
reviewed
Oct 24, 2025
Jefffrey
reviewed
Oct 24, 2025
Comment on lines
+125
to
+135
| However, if you were directly constructing `FileScanConfigBuilder` from a `FileScanConfig` (via the `From` trait) or accessing its internal fields, you may need to update your code. | ||
|
|
||
| **Before:** | ||
|
|
||
| ```rust,ignore | ||
| let builder = FileScanConfigBuilder { | ||
| file_schema: my_schema, | ||
| table_partition_cols: partition_cols, | ||
| ... | ||
| }; | ||
| ``` |
Contributor
There was a problem hiding this comment.
I think this is a hallucination? Fields in FileScanConfigBuilder aren't public so users wouldn't be able to construct it manually
Contributor
Author
There was a problem hiding this comment.
Yup you're totally right, I thought they were hence making this PR. Seems like no breaking change :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated by Claude, but looks good to me :)