-
Notifications
You must be signed in to change notification settings - Fork 1.8k
perf: optimize CASE WHEN lookup table (2.5-22.5 times faster) #18183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rluvaton
wants to merge
55
commits into
apache:main
Choose a base branch
from
rluvaton:improve-performance-for-literal-mapping
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,584
−33
Open
Changes from 54 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
714f9d6
move case to a folder for later additions
rluvaton b4b1970
started implementation for literal lookup for case when
rluvaton 1045071
feat: add to `ExprProperties` the `volatility`
rluvaton 9a74f79
extract and cleanup
rluvaton 98d2cca
finish
rluvaton cfaf4a3
cleanup
rluvaton f958882
format
rluvaton 1787d54
add benchmarks for lookup
rluvaton b2d4b51
fix test
rluvaton 81d82e3
remove
rluvaton a7f54b4
remove
rluvaton 6793388
cleanup
rluvaton d944825
format and lint
rluvaton d3d5a32
bench: create benchmark for lookup table like case when
rluvaton 154710b
added comment
rluvaton 3a8db91
format
rluvaton de1cd81
Merge branch 'refs/heads/add-benchmark-for-lookup-table-case-when' in…
rluvaton e8f5cbb
only keep first occurrence
rluvaton a803734
add license header
rluvaton e0e1057
Merge branch 'main' into improve-performance-for-literal-mapping
rluvaton ca059da
fix doc
rluvaton 4ebacb4
fix null handling in WHEN
rluvaton 10e745a
Merge branch 'main' into improve-performance-for-literal-mapping
rluvaton 934f783
revert format
rluvaton 601bcf3
format
rluvaton d39d0d5
Merge branch 'main' into improve-performance-for-literal-mapping
rluvaton bdefaa9
added more tests
rluvaton ac95e2c
cleanup and finish adding tests
rluvaton 1723460
lint and format
rluvaton e9e5ec4
Merge branch 'main' into improve-performance-for-literal-mapping
rluvaton 5ea4395
fix conflicts
rluvaton a6ec444
use different word to bypass the typo check
rluvaton af5ae5d
Merge branch 'main' into improve-performance-for-literal-mapping
rluvaton d0f1b47
fix conflicts and some cr comments
rluvaton 9190296
fix conflict and cleanup
rluvaton ba85573
cr
rluvaton e875fba
cr
rluvaton 5dbdc46
cr
rluvaton 6db0d61
change to Box from Arc
rluvaton 2a90280
rename
rluvaton 2ff8201
update based on CR
rluvaton e42a681
Merge branch 'main' into improve-performance-for-literal-mapping
rluvaton b615de5
format
rluvaton d670ad1
Merge branch 'main' into improve-performance-for-literal-mapping
rluvaton e59d751
format
rluvaton 41f0336
Merge branch 'main' into improve-performance-for-literal-mapping
rluvaton 1e322b2
cast for now to avoid bugs
rluvaton b4e4f6b
avoid cast to avoid bugs
rluvaton 17d5cac
Merge branch 'main' into improve-performance-for-literal-mapping
rluvaton d26d8bd
fix doc
rluvaton 33ab3f1
support dictionary as keys and cleanup
rluvaton 0cc93a6
fix bug in case when
rluvaton eeb40c5
Merge branch 'main' into improve-performance-for-literal-mapping
rluvaton 834b06f
add back the dep
rluvaton 537642b
lint
rluvaton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick, but it looks like these should be kept in alphabetical order.