fix: Remove duplicate filter from CrossJoin unparsing
#17382
Merged
+45
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-faria
approved these changes
Sep 4, 2025
Comment on lines
-699
to
-705
| self.select_to_sql_recursively( | ||
| right_plan.as_ref(), | ||
| query, | ||
| select, | ||
| &mut right_relation, | ||
| )?; | ||
|
|
Contributor
There was a problem hiding this comment.
Maybe someone more knowledgeable could provide some context to this repeated call, but since all tests still work there doesn't seem to be a problem.
Contributor
There was a problem hiding this comment.
I agree -- it seems like a copy/paste bug to me.
My git archeology suggests it came in the initial PR from @backkem
alamb
approved these changes
Sep 4, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @jonathanc-n and @nuno-faria for the review
Jefffrey
approved these changes
Sep 5, 2025
Comment on lines
-699
to
-705
| self.select_to_sql_recursively( | ||
| right_plan.as_ref(), | ||
| query, | ||
| select, | ||
| &mut right_relation, | ||
| )?; | ||
|
|
destrex271
pushed a commit
to destrex271/datafusion
that referenced
this pull request
Sep 5, 2025
* fix: Remove duplicate filter from `CrossJoin` unparsing * move test * add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Removes the second recursive traversal inside
LogicalPlan::Join, it was causing duplicate filters to pop up when gathering filters. Not sure what the reasoning for this second right side traversal was in the first place.Are these changes tested?
Are there any user-facing changes?