Improve field naming in first_value, last_value implementation #16631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the "requirement_satisfied" fields to "is_input_pre_ordered". It is now slightly more obvious what exactly requirement is satisfied.
findepi
deleted the
findepi/improve-field-naming-in-first-value-last-value-implementation-97ddad
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
The naming is good, but can be perfected. Relates to #16625 (review)
What changes are included in this PR?
Rename the "requirement_satisfied" fields to "is_input_pre_ordered". It is now slightly more obvious what exactly requirement is satisfied.
Are these changes tested?
existing tests
Are there any user-facing changes?
no