Skip to content

Support Duration in min/max agg functions #15310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2025
Merged

Support Duration in min/max agg functions #15310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42ec510
Support min/max agg functions on values of duration type
svranesevic Mar 19, 2025
6155986
Add tests for GROUP BY as well
alamb Mar 19, 2025
de4e066
Merge remote-tracking branch 'apache/main' into duration_min_max_agg
alamb Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions datafusion/functions-aggregate/src/min_max.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ mod min_max_bytes;

use arrow::array::{
ArrayRef, BinaryArray, BinaryViewArray, BooleanArray, Date32Array, Date64Array,
Decimal128Array, Decimal256Array, Float16Array, Float32Array, Float64Array,
Int16Array, Int32Array, Int64Array, Int8Array, IntervalDayTimeArray,
Decimal128Array, Decimal256Array, DurationMicrosecondArray, DurationMillisecondArray,
DurationNanosecondArray, DurationSecondArray, Float16Array, Float32Array,
Float64Array, Int16Array, Int32Array, Int64Array, Int8Array, IntervalDayTimeArray,
IntervalMonthDayNanoArray, IntervalYearMonthArray, LargeBinaryArray,
LargeStringArray, StringArray, StringViewArray, Time32MillisecondArray,
Time32SecondArray, Time64MicrosecondArray, Time64NanosecondArray,
Expand Down Expand Up @@ -518,6 +519,33 @@ macro_rules! min_max_batch {
$OP
)
}
DataType::Duration(TimeUnit::Second) => {
typed_min_max_batch!($VALUES, DurationSecondArray, DurationSecond, $OP)
}
DataType::Duration(TimeUnit::Millisecond) => {
typed_min_max_batch!(
$VALUES,
DurationMillisecondArray,
DurationMillisecond,
$OP
)
}
DataType::Duration(TimeUnit::Microsecond) => {
typed_min_max_batch!(
$VALUES,
DurationMicrosecondArray,
DurationMicrosecond,
$OP
)
}
DataType::Duration(TimeUnit::Nanosecond) => {
typed_min_max_batch!(
$VALUES,
DurationNanosecondArray,
DurationNanosecond,
$OP
)
}
other => {
// This should have been handled before
return internal_err!(
Expand Down Expand Up @@ -1597,7 +1625,7 @@ mod tests {
assert_eq!(
min_res,
ScalarValue::IntervalYearMonth(Some(IntervalYearMonthType::make_value(
-2, 4
-2, 4,
)))
);

Expand All @@ -1609,7 +1637,7 @@ mod tests {
assert_eq!(
max_res,
ScalarValue::IntervalYearMonth(Some(IntervalYearMonthType::make_value(
5, 34
5, 34,
)))
);

Expand Down
32 changes: 32 additions & 0 deletions datafusion/sqllogictest/test_files/aggregate.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3807,6 +3807,38 @@ SELECT MIN(value), MAX(value) FROM timestampmicrosecond
statement ok
DROP TABLE timestampmicrosecond;

# min_duration, max_duration
statement ok
create table d
as values
(arrow_cast(1, 'Duration(Second)'), arrow_cast(2, 'Duration(Millisecond)'), arrow_cast(3, 'Duration(Microsecond)'), arrow_cast(4, 'Duration(Nanosecond)'), 1),
(arrow_cast(11, 'Duration(Second)'),arrow_cast(22, 'Duration(Millisecond)'), arrow_cast(33, 'Duration(Microsecond)'), arrow_cast(44, 'Duration(Nanosecond)'), 1);

query ????
SELECT min(column1), min(column2), min(column3), min(column4) FROM d;
Copy link
Contributor

@alamb alamb Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified these queries fail without this change:

> SELECT min(column1), min(column2), min(column3), min(column4) FROM d;
Internal error: Min/Max accumulator not implemented for type Duration(Second).
This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker
>

----
0 days 0 hours 0 mins 1 secs 0 days 0 hours 0 mins 0.002 secs 0 days 0 hours 0 mins 0.000003 secs 0 days 0 hours 0 mins 0.000000004 secs

query ????
SELECT max(column1), max(column2), max(column3), max(column4) FROM d;
----
0 days 0 hours 0 mins 11 secs 0 days 0 hours 0 mins 0.022 secs 0 days 0 hours 0 mins 0.000033 secs 0 days 0 hours 0 mins 0.000000044 secs

# GROUP BY follows a different code path
Copy link
Contributor

@alamb alamb Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added some tests when there is GROUP BY in the query as that takes a different code path

I actually double checked and there is a way to make this kind of query faster, which I filed as

query ????I
SELECT min(column1), min(column2), min(column3), min(column4), column5 FROM d GROUP BY column5;
----
0 days 0 hours 0 mins 1 secs 0 days 0 hours 0 mins 0.002 secs 0 days 0 hours 0 mins 0.000003 secs 0 days 0 hours 0 mins 0.000000004 secs 1

query ????I
SELECT max(column1), max(column2), max(column3), max(column4), column5 FROM d GROUP BY column5;
----
0 days 0 hours 0 mins 11 secs 0 days 0 hours 0 mins 0.022 secs 0 days 0 hours 0 mins 0.000033 secs 0 days 0 hours 0 mins 0.000000044 secs 1


statement ok
drop table d;

# max_bool
statement ok
CREATE TABLE max_bool (value BOOLEAN);
Expand Down