Skip to content

Minor: Deprecate ScalarValue::raw_data #15016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Mar 6, 2025
Merged

Minor: Deprecate ScalarValue::raw_data #15016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions datafusion/common/src/scalar/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2764,8 +2764,10 @@ impl ScalarValue {
Ok(scalars)
}

// TODO: Support more types after other ScalarValue is wrapped with ArrayRef
/// Get raw data (inner array) inside ScalarValue
#[deprecated(
since = "46.0.0",
note = "This function is obsolete. Use `to_array` instead"
)]
pub fn raw_data(&self) -> Result<ArrayRef> {
Copy link
Contributor

@alamb alamb Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @qazxcdswe123 -- this is a nice find.

Per https://datafusion.apache.org/contributor-guide/api-health.html instead of removing this function, can you please mark it as #[deprecated] instead?

Maybe it would be a good time to go remove any deprecated functions from 41 or earlier 🤔

Copy link
Contributor Author

@qazxcdswe123 qazxcdswe123 Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the remind!

And I think to_array is what we meant to do here?

datafusion/datafusion/common/src/scalar/mod.rs

Line 1766 in c0d53ad

pub fn to_array(&self) -> Result<ArrayRef> {

Copy link
Contributor Author

@qazxcdswe123 qazxcdswe123 Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll file another PR to cleanup some old deprecation

match self {
ScalarValue::List(arr) => Ok(arr.to_owned()),
Expand Down