Workaround build failure: Pin quote to 1.0.10 #1499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have requested the author yank the affected version of quote : dtolnay/quote#204 and if that is done, we don't need this PR |
alamb
added a commit
to alamb/datafusion
that referenced
this pull request
Dec 29, 2021
This reverts commit 8d20f14.
Contributor
Author
|
Created #1503 to revert this change (mostly so I don't forget it) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1498
Rationale for this change
Seems like quote needs a newer version of
proc-macro2but that crate is held back by arrow-flight.What changes are included in this PR?
Work around by pinning
quotecrate to an earlier versionAre there any user-facing changes?
deps will hold back
quote