Include struct name on FileScanConfig debug impl #14883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
approved these changes
Feb 26, 2025
|
Thank you @comphead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of
46.0.0#14123DataSourceExecfor provided datasources, removeParquetExec,CsvExec, etc #14224DebugforDataSource#14882Rationale for this change
When working on upgrading delta-rs to use the new DataSourceExec I was super confused that the source printed out like this
Without the struct name 🤯
What changes are included in this PR?
Add the struct name
Are these changes tested?
Are there any user-facing changes?