Fix logical vs physical schema mismatch for aliased now()
#12951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
itsjunetime
approved these changes
Oct 15, 2024
Contributor
itsjunetime
left a comment
itsjunetime
left a comment
There was a problem hiding this comment.
Looks all good to me, thanks for figuring out this one.
alamb
changed the title
now()
alamb
reviewed
Oct 15, 2024
| ))) | ||
| } | ||
|
|
||
| fn is_nullable(&self, _args: &[Expr], _schema: &dyn ExprSchema) -> bool { |
alamb
approved these changes
Oct 15, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @wiedld and @itsjunetime
|
|
||
|
|
||
|
|
||
| query P rowsort |
7 tasks
alamb
approved these changes
Oct 16, 2024
| )) | ||
| GROUP BY ts | ||
| ORDER BY ts | ||
| LIMIT 1; |
Contributor
There was a problem hiding this comment.
I verified that without the code in this PR, this test fails like this:
External error: query failed: DataFusion error: Schema error: No field named ts. Valid fields are table_with_metadata.id, table_with_metadata.name, table_with_metadata.l_name.
[SQL] SELECT ts
FROM ((
SELECT now() AS ts
FROM table_with_metadata
) UNION ALL (
SELECT ts
FROM table_with_metadata
))
GROUP BY ts
ORDER BY ts
LIMIT 1;
at test_files/metadata.slt:128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #12733
We found another bug for aliased now() columns.
Rationale for this change
See the reproducer in the first commit.
Both of the next two commits are required for the fix.
What changes are included in this PR?
get_field_metadatashould handle aliased columns.Also, the
now()udf is not nullable.Are these changes tested?
Yes.
Are there any user-facing changes?
Not really.
Only that the now() udf will return not-nullable (instead of the default impl).