Minor: use ready! macro to simplify FilterExec
#11649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jul 25, 2024
| poll = Poll::Ready(Some(Ok(filtered_batch))); | ||
| break; | ||
| } | ||
| value => { |
Contributor
Author
There was a problem hiding this comment.
The ready! macro returns if the poll is not ready: https://doc.rust-lang.org/std/task/macro.ready.html
This does skip calling baseline_metrics.record_poll below, however, that doesn't do anything with PollPending:
https://docs.rs/datafusion-physical-plan/40.0.0/src/datafusion_physical_plan/metrics/baseline.rs.html#127
comphead
approved these changes
Jul 25, 2024
Dandandan
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The poll loops of the
Streams in the execution form the core state control. It is useful for them to be as simple as possible so the state machine is easy to understandWhile working on #11647 I noticed we could simplify the poll loop in FilterExec using the
ready!macro.What changes are included in this PR?
Use the standard
ready!macro to avoid code repetitionAre these changes tested?
By existing CI
Are there any user-facing changes?