Make Logical Plans more readable by removing extra aliases #10832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
MohamedAbdeen21
force-pushed
the
chained-aliases-in-plans
branch
from
d497725 to
c036309
Compare
MohamedAbdeen21
changed the title
peter-toth
reviewed
Jun 8, 2024
peter-toth
reviewed
Jun 8, 2024
peter-toth
reviewed
Jun 9, 2024
peter-toth
reviewed
Jun 9, 2024
peter-toth
reviewed
Jun 9, 2024
peter-toth
approved these changes
Jun 9, 2024
Contributor
There was a problem hiding this comment.
Looks good, I only have minor suggestions.
cc @alamb
peter-toth
reviewed
Jun 9, 2024
Closed
alamb
approved these changes
Jun 11, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks great -- thank you @MohamedAbdeen21 and @peter-toth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Removing unnecessary aliasing in the logical plan (Check changed tests)
What changes are included in this PR?
Some rules need expressions to be aliased and Common Subexpr Elimination (CSE) rule used to create these aliases. CSE rule now checks if the expr already has an alias before assigning a new one. cc @peter-toth
Are these changes tested?
Yes
Are there any user-facing changes?
Slightly more readable logical plans.