Skip to content

Minor: fix signature fn octect_length() #10726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 2 commits into from
May 30, 2024
Merged

Minor: fix signature fn octect_length() #10726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7289a3f
fix: signature fn octect_length
marvinlanhenke May 30, 2024
4fef091
chore: add test
marvinlanhenke May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions datafusion/core/tests/expr_api/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,23 @@ use std::sync::{Arc, OnceLock};

mod simplification;

#[test]
fn test_octet_length() {
#[rustfmt::skip]
evaluate_expr_test(
octet_length(col("list")),
vec![
"+------+",
"| expr |",
"+------+",
"| 5 |",
"| 18 |",
"| 6 |",
"+------+",
],
);
}

#[test]
fn test_eq() {
// id = '2'
Expand Down
4 changes: 2 additions & 2 deletions datafusion/functions/src/string/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ pub mod expr_fn {
}

#[doc = "returns the number of bytes of a string"]
pub fn octet_length(args: Vec<Expr>) -> Expr {
super::octet_length().call(args)
pub fn octet_length(args: Expr) -> Expr {
super::octet_length().call(vec![args])
}

#[doc = "replace the substring of string that starts at the start'th character and extends for count characters with new substring"]
Expand Down