Revert 10333 / changes to aliasing in CommonSubExprEliminate #10436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
alamb
approved these changes
May 9, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @MohamedAbdeen21
For anyone following along, the rationale to revert is here: #10333 (comment)
cc @peter-toth
This was referenced May 9, 2024
alamb
changed the title
Contributor
|
Thanks again! |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…10436) * Revert "make common expression alias human-readable (apache#10333)" This reverts commit 2a15614. * keep some ok parts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Revert #10333
related to #10280
Rationale for this change
This issue is to be revisited after #10413.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?