Derive PartialOrd for Expr #1015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynexia
approved these changes
Sep 17, 2021
Member
waynexia
left a comment
waynexia
left a comment
There was a problem hiding this comment.
The change looks good to me. Failing CI seems unrelated (looks like the rev of testing submodule is wrong)
Contributor
|
Also LGTM if testing module change is reverted (and I guess CI succeeds) |
Contributor
Author
Good eyes -- thank you for the spot @waynexia . I will revert that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Resolves #1014
Rationale for this change
We would like to order
Exprs in a consistent way in our tests. See details on https://github.com/influxdata/influxdb_iox/pull/2564 in https://github.com/influxdata/influxdb_iox/pull/2564#discussion_r710817261This also is a necessary (but not sufficient) step towards being able to use
Exprs in sets and maps (still need to implementOrdandHash) which might have helped @waynexia in #792 with CSE and would help with other algebriac transformations in the future.What changes are included in this PR?
Are there any user-facing changes?
Can now compare Exprs