Backport to 37: fix NamedStructField should be rewritten in OperatorToFunction in subquery regression
#10103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
10 tasks
Contributor
Author
|
@andygrove do you happen to have time to review / approve this PR for the 37.1.0 release? |
viirya
approved these changes
Apr 17, 2024
viirya
reviewed
Apr 17, 2024
| function_rewrites, | ||
| options, | ||
| )?); | ||
| Ok(subquery) |
Member
There was a problem hiding this comment.
This change doesn't look like the same as the original PR, but looks reasonable.
Contributor
Author
There was a problem hiding this comment.
You are correct -- I should have pointed that out. The original PR uses the TreeNode API, but that TreeNode API is not available in 37.0.0 so I used an earlier commit from #10032 that did not use the tree node api (but has the same tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(note this targets
branch-37, NOTmain)Which issue does this PR close?
Part of 37 maintenance release #9904
Rationale for this change
Backport fixes for regressions
What changes are included in this PR?
Backport #10032, fix for #10029 to
branch-37Note this was only the first commit (as the TreeNode improvements are not on 37.0.0)
Are these changes tested?
tests are included in backport
Are there any user-facing changes?