In the documentation for PartitionEvaluator::evaluate_all_with_rank:
https://docs.rs/datafusion/latest/datafusion/logical_expr/trait.PartitionEvaluator.html#method.evaluate_all_with_rank
Is there a typo in the example table? It shows the ranks as being 1, 1, 3, 4, 5, but shouldn't it be 1, 1, 3, 4, 4? Or am I just misunderstanding the RANK function somehow?
It's a minor thing, but it did trip me up when I was trying to understand this API.
Also, in the evaluate method above it, there appears to be an extraneous "x":
Evaluate window function on a range of rows in an input partition.x
I hope this isn't a nuisance ticket. Are these okay or should I batch up typos/documentation improvements into bigger issues? Or should I just bypass opening an issue and just submit a PR?
In the documentation for
PartitionEvaluator::evaluate_all_with_rank:https://docs.rs/datafusion/latest/datafusion/logical_expr/trait.PartitionEvaluator.html#method.evaluate_all_with_rank
Is there a typo in the example table? It shows the ranks as being
1,1,3,4,5, but shouldn't it be1,1,3,4,4? Or am I just misunderstanding theRANKfunction somehow?It's a minor thing, but it did trip me up when I was trying to understand this API.
Also, in the
evaluatemethod above it, there appears to be an extraneous "x":Evaluate window function on a range of rows in an input partition.xI hope this isn't a nuisance ticket. Are these okay or should I batch up typos/documentation improvements into bigger issues? Or should I just bypass opening an issue and just submit a PR?