Skip to content

Conversation

@milenkovicm
Copy link
Contributor

... in create function

closes #1183

@milenkovicm
Copy link
Contributor Author

Hey @alamb this is follow up on #1159, can you please have a look when you get chance. Thanks!

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @milenkovicm

@coveralls
Copy link

coveralls commented Mar 24, 2024

Pull Request Test Coverage Report for Build 8410133512

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 87.881%

Totals Coverage Status
Change from base Build 8266982631: 0.01%
Covered Lines: 20486
Relevant Lines: 23311

💛 - Coveralls

@alamb alamb merged commit 4472789 into apache:main Mar 24, 2024
@milenkovicm milenkovicm deleted the generic_double_dollar_fix branch March 24, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for $$ in CREATE FUNCTION for generic dialect

3 participants