feat: Support casting string non int numeric types #2835
+481
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2835 +/- ##
============================================
- Coverage 56.12% 54.39% -1.74%
- Complexity 976 1435 +459
============================================
Files 119 167 +48
Lines 11743 15185 +3442
Branches 2251 2523 +272
============================================
+ Hits 6591 8260 +1669
- Misses 4012 5709 +1697
- Partials 1140 1216 +76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
martin-g
reviewed
Dec 2, 2025
| testAnsi = false) | ||
| test("cast StringType to DoubleType") { | ||
| Seq(true, false).foreach { v => | ||
| castTest(specialValues.toDF("a"), DataTypes.FloatType, testAnsi = v) |
Member
There was a problem hiding this comment.
Suggested change
| castTest(specialValues.toDF("a"), DataTypes.FloatType, testAnsi = v) | |
| castTest(specialValues.toDF("a"), DataTypes.DoubleType, testAnsi = v) |
| ) -> SparkResult<ArrayRef> { | ||
| let string_array = array | ||
| .as_any() | ||
| .downcast_ref::<StringArray>() |
Member
There was a problem hiding this comment.
Suggested change
| .downcast_ref::<StringArray>() | |
| .downcast_ref::<GenericStringArray>() |
To support LargeUtf8
coderfender
changed the title
coderfender
force-pushed
the
support_string_non_int_numeric_types
branch
from
e7a1144 to
79d0ea9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #326
Rationale for this change
Comet surrently supports some basic string -> non int casts and this PR essentially extends on that to support all possible casts from string to non-int numeric (float, double and decimal) types
What changes are included in this PR?
Updates to cast logic to support exhaustive casts from string to numeric (non-int) types
How are these changes tested?
Unit tests and fuzz tests