Skip to content

Conversation

@yjhjstz
Copy link
Member

@yjhjstz yjhjstz commented Aug 21, 2024

Previously, fsync was set to off by default unless NUM_PRIMARY_MIRROR_PAIRS was zero or fsync was explicitly set to on. This change ensures that fsync is always on, improving data durability and consistency by default in the demo setup.

fix #544


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

Previously, fsync was set to off by default unless NUM_PRIMARY_MIRROR_PAIRS was zero or fsync was explicitly set to on.
This change ensures that fsync is always on, improving data durability and consistency by default in the demo setup.
@my-ship-it my-ship-it merged commit b72c1f7 into apache:main Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] gp_replica_check fails frequently due to inconsistencies detected between primary and mirror node

2 participants