[improve] Enable hostname specification as a script argument for topology script #4670
+142
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when using
ScriptBasedMappingfor network location resolution via the topology script, only IP addresses are passed to the script.In some situations it is preferable to pass hostnames instead of IPs.
This PR introduces a configuration option to enable that behavior.
Changes
networkTopologyScriptUseHostNameArgsfalsetrue,ScriptBasedMappingpasses hostnames instead of IP addresses to the topology script.CachedDNSToSwitchMappingandScriptBasedMapping.RawScriptBasedMappingto respect this setting.TestRackawareEnsemblePlacementPolicyUsingScript.testUseHostnameArgsOption