Skip to content

Conversation

@shustsud
Copy link
Contributor

@shustsud shustsud commented Oct 3, 2025

Motivation

Currently, when using ScriptBasedMapping for network location resolution via the topology script, only IP addresses are passed to the script.
In some situations it is preferable to pass hostnames instead of IPs.
This PR introduces a configuration option to enable that behavior.

Changes

  • Added a new configuration key:
    networkTopologyScriptUseHostNameArgs
    • default: false
    • when set to true, ScriptBasedMapping passes hostnames instead of IP addresses to the topology script.
  • Updated CachedDNSToSwitchMapping and ScriptBasedMapping.RawScriptBasedMapping to respect this setting.
  • Added corresponding unit test:
    TestRackawareEnsemblePlacementPolicyUsingScript.testUseHostnameArgsOption

@shustsud
Copy link
Contributor Author

rerun failure checks

@shustsud shustsud force-pushed the hostname_arg_network_resolution branch from de35c76 to 57602fc Compare November 18, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant