BIGTOP-3526: Remove phantomjs dependency from yarn-ui #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwasakims
reviewed
Mar 16, 2021
Member
|
Since the PhantomJS is only used for testing, removing it would be ok. Yarn UI 2 built with the modified yarn.lock worked for me. |
iwasakims
changed the title
Haoop Yarn-UI depends on phantomjs (optional) while there is not prebuilt binary other than x86 platform. And this will cause hadoop build failure as yarn-ui has been enabled by BIGTOP-3456. Change-Id: I10d034d3172787f9667d53d44b1663a04c9fdf93 Signed-off-by: Jun He <[email protected]>
iwasakims
approved these changes
Mar 17, 2021
|
(FWIW, Ubuntu Bionic and Focal have official phantomjs binary packages for ARM) HADOOP-17723 / apache/hadoop#3037 |
Member
|
Thanks, @jojochuang. The information is useful for Bigtop too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haoop Yarn-UI depends on phantomjs (optional) while there is
not prebuilt binary other than x86 platform. And this will
cause hadoop build failure as yarn-ui has been enabled by BIGTOP-3456.
Change-Id: I10d034d3172787f9667d53d44b1663a04c9fdf93
Signed-off-by: Jun He [email protected]