Skip to content

BIGTOP-4238: Collect metrics for disk I/O and file descriptors#83

Merged
kevinw66 merged 14 commits intoapache:mainfrom
Cat-Drink:BIGTOP-4238
Oct 19, 2024
Merged

BIGTOP-4238: Collect metrics for disk I/O and file descriptors#83
kevinw66 merged 14 commits intoapache:mainfrom
Cat-Drink:BIGTOP-4238

Conversation

@Cat-Drink
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

@wuchunfu wuchunfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @Cat-Drink thanks

@lhpqaq
Copy link
Copy Markdown
Member

lhpqaq commented Oct 15, 2024

You may need to run mvn spotless:apply.

@Cat-Drink
Copy link
Copy Markdown
Contributor Author

You may need to run mvn spotless:apply.

thanks for your guidance

@kevinw66
Copy link
Copy Markdown
Contributor

The title should start with BIGTOP-4238

@Cat-Drink Cat-Drink changed the title Bigtop 4238: New metrics added to the Agent and the Server retrieves metrics and provides an interface BIGTOP-4238: New metrics added to the Agent and the Server retrieves metrics and provides an interface Oct 15, 2024
@Cat-Drink Cat-Drink requested a review from wuchunfu October 16, 2024 13:34
Copy link
Copy Markdown
Member

@wuchunfu wuchunfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuxiaofengfu
Copy link
Copy Markdown
Contributor

fuxiaofengfu commented Oct 19, 2024

on API "/api/monitoring/agentinfo": disk info of AgentInfo could display with separate file system ?
from
{
"hostname": "linux-follower-2",
"iPv4addr": "192.168.65.6",
"cpuInfo": "QEMU Virtual CPU version 2.5+",
"time": "2024-10-19T19:18:49",
"os": "Linux",
"architecture": "amd64",
"physical_cores": "1",
"memIdle": 1500139520,
"memTotal": 3840593920,
"diskFreeSpace": 125490970624,
"diskTotalSpace": 131423035392
}
to
{
"hostname": "linux-follower-2",
"iPv4addr": "192.168.65.6",
"cpuInfo": "QEMU Virtual CPU version 2.5+",
"time": "2024-10-19T19:18:49",
"os": "Linux",
"architecture": "amd64",
"physical_cores": "1",
"memIdle": 1500139520,
"memTotal": 3840593920,
"device0Name": "/dev/mapper/rl-home"
"device0FreeSpace": 125490970624,
"device0TotalSpace": 131423035392,
"device1Name": "/dev/mapper/rl-root"
"device1FreeSpace": 125490970624,
"device1TotalSpace": 131423035392,
}

DISK IO could also displayed with file system related ? not only displayed physical disk. as maybe we don't know which file system used higher Disk IO.
such as exists disk sda, two part in it. one is /dev/sda1 mount on / , another is /dev/sda2 mount on /home, then we can clear / and /home are using higher disk IO

@Cat-Drink
Copy link
Copy Markdown
Contributor Author

on API "/api/monitoring/agentinfo": disk info of AgentInfo could display with separate file system ? from { "hostname": "linux-follower-2", "iPv4addr": "192.168.65.6", "cpuInfo": "QEMU Virtual CPU version 2.5+", "time": "2024-10-19T19:18:49", "os": "Linux", "architecture": "amd64", "physical_cores": "1", "memIdle": 1500139520, "memTotal": 3840593920, "diskFreeSpace": 125490970624, "diskTotalSpace": 131423035392 } to { "hostname": "linux-follower-2", "iPv4addr": "192.168.65.6", "cpuInfo": "QEMU Virtual CPU version 2.5+", "time": "2024-10-19T19:18:49", "os": "Linux", "architecture": "amd64", "physical_cores": "1", "memIdle": 1500139520, "memTotal": 3840593920, "device0Name": "/dev/mapper/rl-home" "device0FreeSpace": 125490970624, "device0TotalSpace": 131423035392, "device1Name": "/dev/mapper/rl-root" "device1FreeSpace": 125490970624, "device1TotalSpace": 131423035392, }

DISK IO could also displayed with file system related ? not only displayed physical disk. as maybe we don't know which file system used higher Disk IO. such as exists disk sda, two part in it. one is /dev/sda1 mount on / , another is /dev/sda2 mount on /home, then we can clear / and /home are using higher disk IO

ok,i understand

@Cat-Drink
Copy link
Copy Markdown
Contributor Author

on API "/api/monitoring/agentinfo": disk info of AgentInfo could display with separate file system ? from { "hostname": "linux-follower-2", "iPv4addr": "192.168.65.6", "cpuInfo": "QEMU Virtual CPU version 2.5+", "time": "2024-10-19T19:18:49", "os": "Linux", "architecture": "amd64", "physical_cores": "1", "memIdle": 1500139520, "memTotal": 3840593920, "diskFreeSpace": 125490970624, "diskTotalSpace": 131423035392 } to { "hostname": "linux-follower-2", "iPv4addr": "192.168.65.6", "cpuInfo": "QEMU Virtual CPU version 2.5+", "time": "2024-10-19T19:18:49", "os": "Linux", "architecture": "amd64", "physical_cores": "1", "memIdle": 1500139520, "memTotal": 3840593920, "device0Name": "/dev/mapper/rl-home" "device0FreeSpace": 125490970624, "device0TotalSpace": 131423035392, "device1Name": "/dev/mapper/rl-root" "device1FreeSpace": 125490970624, "device1TotalSpace": 131423035392, }

DISK IO could also displayed with file system related ? not only displayed physical disk. as maybe we don't know which file system used higher Disk IO. such as exists disk sda, two part in it. one is /dev/sda1 mount on / , another is /dev/sda2 mount on /home, then we can clear / and /home are using higher disk IO

Regarding Disk IO, we can obtain information about devices such as /dev/sda, /dev/sdb, etc.

@Cat-Drink Cat-Drink requested a review from wuchunfu October 19, 2024 13:30
@kevinw66 kevinw66 changed the title BIGTOP-4238: New metrics added to the Agent and the Server retrieves metrics and provides an interface BIGTOP-4238: Collect metrics for disk I/O and file descriptors Oct 19, 2024
@kevinw66
Copy link
Copy Markdown
Contributor

Thanks @Cat-Drink @lhpqaq @fuxiaofengfu @wuchunfu

@kevinw66 kevinw66 merged commit 8a8f7ec into apache:main Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants