[BEAM-4417] Fix the expected encoding of BigQuery's NUMERIC type when reading from Avro #5948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m Avro. The NUMERIC data type is represented in Avro using the BYTES type with the DECIMAL logical type. I verified this change using BigQueryTornadoes.java, which I modified (locally) to write NUMERIC values to BigQuery, then read them back using Dataflow and write them to a new BigQuery table. The test failed as expected without this change, but now passes, and I can see the correct content in the table. Context: #5755 (comment)
Author
|
@kennknowles I'd appreciate it if you could take a look at this PR as well, thanks! |
ElliottBrossard
changed the title
Member
|
I will review this today. Thank you @ElliottBrossard |
Member
|
Run Java PostCommit |
Member
|
The change LGTM, however it is breaking tests. cc: @akedin will take a look it error. |
Contributor
|
Looking at it, can reproduce, but not sure how these changes could have affected the failing test. Probably it was already broken, checking on master |
Contributor
|
Ah, it fails on master and I think it's a known issue. @apilloud , @amaliujia can you take a look? |
Contributor
Contributor
|
Run Java PostCommit |
Contributor
|
LGTM |
Author
|
@aaltay, any comments? Thanks! |
aaltay
approved these changes
Jul 17, 2018
Member
|
Thank you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NUMERIC data type is represented in Avro using the BYTES type with the DECIMAL logical type.
I verified this change using BigQueryTornadoes.java, which I modified (locally) to write NUMERIC values to BigQuery, then read them back using Dataflow and write them to a new BigQuery table. The test failed as expected without this change, but now passes, and I can see the correct content in the table.
Context: #5755 (comment)