fix error in BigQueryUtils when retrieving non existent avro field #30720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @bvolpato for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
tilgalas
changed the title
Contributor
Author
|
Run PostCommit_Java_Dataflow |
Abacn
approved these changes
Apr 1, 2024
Contributor
|
V2 PostCommit passed; V1 PostCommit failed quota issue on unrelated tests, merging for now |
hjtran
pushed a commit
to hjtran/beam
that referenced
this pull request
Apr 4, 2024
…pache#30720) * dump the record schema in BigQueryUtils exception message for debugging purposes * include the right test * check if the field exists in the record before fetching it * add test, restore previous exception message * trigger V2 PostCommit as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30730
fixes #30729
An integration test called
BigQueryIOStorageReadIT.testBigQueryStorageReadProjectionPushdownis failing - this is because the pushdown optimizer projects the record retrieved from the bigquery by removing unusedstring_field. Later thetoBeamRowconversion method iterates through the beam schema's fields and tries to extract a value from the avro record for every such field, including the one that has been removed by the optimizer - avro version 1.8 didn't have a problem with attempting to get a value from non-existent field - it simply returnednull, but things have changed in version 1.11, and now this operation throws an exception. The fix is to check whether the field exists in the record before attempting to fetch its value. Also - added a unit test specifically for this situationThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.