Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.
This repository was archived by the owner on May 12, 2021. It is now read-only.

Possible NullPointerException in InstanceActionHandler #31

@jordanly

Description

@jordanly

After introducing the 'slaAware' field in this commit, there has been a possible NullPointerException in this line. This happens when an update only kills instances. There is no desiredState, so getDesiredState().getTask() will try to act on a null object. Other places in the code guard against this case by checking isSetDesiredState() before retrieval.

We should properly handle nulls in this case, and add generic end to end tests for only adding instances and only removing instances with updates.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions