GH-49649: [R] R non-API calls reported on CRAN#49653
Open
thisisnic wants to merge 4 commits intoapache:mainfrom
Open
GH-49649: [R] R non-API calls reported on CRAN#49653thisisnic wants to merge 4 commits intoapache:mainfrom
thisisnic wants to merge 4 commits intoapache:mainfrom
Conversation
github-actions
bot
added
Component: R
awaiting committer review
Member
Author
|
Once this is reviewed, we should rebase it on #49655 before this so we can check it properly. |
jonkeane
reviewed
Apr 3, 2026
jonkeane
reviewed
Apr 3, 2026
github-actions
bot
added
awaiting changes
jonkeane
reviewed
Apr 3, 2026
jonkeane
reviewed
Apr 3, 2026
Comment on lines
-211
to
+224
| #if R_VERSION >= R_Version(4, 5, 0) | ||
| SEXP xp = R_getVarEx(arrow::r::symbols::xp, self, FALSE, R_UnboundValue); | ||
| #if R_VERSION >= R_Version(4, 6, 0) | ||
| if (!R_existsVarInFrame(self, arrow::r::symbols::xp)) { | ||
| cpp11::stop("Invalid: self$`.:xp:.` is NULL"); | ||
| } | ||
| SEXP xp = R_getVar(arrow::r::symbols::xp, self, FALSE); | ||
| if (xp == R_NilValue) { | ||
| cpp11::stop("Invalid: self$`.:xp:.` is NULL"); | ||
| } | ||
| #else | ||
| SEXP xp = Rf_findVarInFrame(self, arrow::r::symbols::xp); | ||
| #endif | ||
| if (xp == R_UnboundValue || xp == R_NilValue) { | ||
| cpp11::stop("Invalid: self$`.:xp:.` is NULL"); | ||
| } | ||
| #endif |
Member
There was a problem hiding this comment.
We might need three branches here: <4.5, >=4.5<4.6, >=4.6 so that we avoid Rf_findVarInFrame on oldrel right?
Member
Author
|
Sorry Jon, this is me doing a crap job of reviewing AI code; I'm redoing this and being more thorough about my checking. Non-Claude models seem to have gotten better at convincing me they're correct without actually being more correct. |
thisisnic
force-pushed
the
GH-49649-more-non-api
branch
from
c4eff7e to
734790f
Compare
github-actions
bot
added
awaiting change review
Member
Author
|
The changes on this PR won't affect |
github-actions
bot
added
awaiting changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
CRAN reports non-API calls
What changes are included in this PR?
Swap 'em out
Are these changes tested?
I'll test with CI
Are there any user-facing changes?
Nah
AI usage
Used Claude, asked it lots of questions about what it was doing and why, answers sounded reasonable.