GH-49623: [CI][Python] Install built wheel on Windows verification and test in isolation#49624
GH-49623: [CI][Python] Install built wheel on Windows verification and test in isolation#49624raulcd merged 3 commits intoapache:mainfrom
Conversation
…ion and test it in isolation
|
@github-actions crossbow submit verify-rc-source-windows |
|
|
|
Revision: 52c1e80 Submitted crossbow builds: ursacomputing/crossbow @ actions-21ee3a48ec
|
|
@github-actions crossbow submit verify-rc-source-windows |
|
Revision: c86f2ec Submitted crossbow builds: ursacomputing/crossbow @ actions-d1e4a1c363
|
|
@github-actions crossbow submit verify-rc-source-windows |
|
Revision: 4e5fcbe Submitted crossbow builds: ursacomputing/crossbow @ actions-157c1a6a9f
|
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
This fixes CI for Windows verification and is related to the changes I did for scikit-build-core. I'll just merge it. Happy to follow up if necessary.
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 5c78ddf. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 25 possible false positives for unstable benchmarks that are known to sometimes produce them. |
1 participant
Rationale for this change
Verification job is currently failing on Windows.
What changes are included in this PR?
With the changes on sckit-build-core we changed how we build the wheel on Windows verification. Previously we were doing editable installations. For verification we should install the built wheel and test on isolation, not in-source.
Are these changes tested?
Yes via CI
Are there any user-facing changes?
No