GH-47921: [C++] Implement substrait option in Meson #48016
Merged
+275
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
WillAyd
force-pushed
the
meson-add-substrait
branch
2 times, most recently
from
802686a to
fcd620d
Compare
|
Looks like this will need #48017 first |
WillAyd
force-pushed
the
meson-add-substrait
branch
from
fcd620d to
35b71b3
Compare
|
@kou if you get a chance to look at this one let me know - no rush! |
kou
approved these changes
Nov 4, 2025
cpp/src/arrow/engine/meson.build
Outdated
| ) | ||
| meson.override_dependency('arrow-substrait', arrow_substrait_dep) | ||
|
|
||
| pkg_config_cflags = get_option('default_library') == 'static' ? '-DARROW_ENGINE_STATIC' : '' |
There was a problem hiding this comment.
How about avoid using empty string?
Suggested change
| pkg_config_cflags = get_option('default_library') == 'static' ? '-DARROW_ENGINE_STATIC' : '' | |
| pkg_config_cflags = [] | |
| if get_option('default_library') == 'static' | |
| pkg_config_cflags += ['-DARROW_ENGINE_STATIC'] | |
| endif |
github-actions
bot
added
awaiting merge
WillAyd
force-pushed
the
meson-add-substrait
branch
from
35b71b3 to
2845099
Compare
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 7185902. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This implements the substrait option in Meson
What changes are included in this PR?
Meson configuration changes to allow substrait
Are these changes tested?
Yes
Are there any user-facing changes?
No