Skip to content

ARROW-5412: [Integration] Add Java option for netty reflection #4522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BryanCutler wants to merge 2 commits into from
Closed

ARROW-5412: [Integration] Add Java option for netty reflection #4522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6f0eee
Added '-Dio.netty.tryReflectionSetAccessible=true' property to Java i…
BryanCutler Jun 11, 2019
25bec06
fix flake check
BryanCutler Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions integration/integration_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1307,6 +1307,8 @@ class JavaTester(Tester):

FLIGHT_PORT = 31338

JAVA_OPTS = ['-Dio.netty.tryReflectionSetAccessible=true']

_arrow_version = load_version_from_pom()
ARROW_TOOLS_JAR = os.environ.get(
'ARROW_JAVA_INTEGRATION_JAR',
Expand All @@ -1326,8 +1328,8 @@ class JavaTester(Tester):
name = 'Java'

def _run(self, arrow_path=None, json_path=None, command='VALIDATE'):
cmd = ['java', '-cp', self.ARROW_TOOLS_JAR,
'org.apache.arrow.tools.Integration']
cmd = ['java'] + self.JAVA_OPTS + \
['-cp', self.ARROW_TOOLS_JAR, 'org.apache.arrow.tools.Integration']

if arrow_path is not None:
cmd.extend(['-a', arrow_path])
Expand All @@ -1349,35 +1351,34 @@ def json_to_file(self, json_path, arrow_path):
return self._run(arrow_path, json_path, 'JSON_TO_ARROW')

def stream_to_file(self, stream_path, file_path):
cmd = ['java', '-cp', self.ARROW_TOOLS_JAR,
'org.apache.arrow.tools.StreamToFile',
stream_path, file_path]
cmd = ['java'] + self.JAVA_OPTS + \
['-cp', self.ARROW_TOOLS_JAR,
'org.apache.arrow.tools.StreamToFile', stream_path, file_path]
if self.debug:
print(' '.join(cmd))
run_cmd(cmd)

def file_to_stream(self, file_path, stream_path):
cmd = ['java', '-cp', self.ARROW_TOOLS_JAR,
'org.apache.arrow.tools.FileToStream',
file_path, stream_path]
cmd = ['java'] + self.JAVA_OPTS + \
['-cp', self.ARROW_TOOLS_JAR,
'org.apache.arrow.tools.FileToStream', file_path, stream_path]
if self.debug:
print(' '.join(cmd))
run_cmd(cmd)

def flight_request(self, port, json_path):
cmd = ['java', '-cp', self.ARROW_FLIGHT_JAR,
self.ARROW_FLIGHT_CLIENT,
'-port', str(port),
'-j', json_path]
cmd = ['java'] + self.JAVA_OPTS + \
['-cp', self.ARROW_FLIGHT_JAR, self.ARROW_FLIGHT_CLIENT,
'-port', str(port), '-j', json_path]
if self.debug:
print(' '.join(cmd))
run_cmd(cmd)

@contextlib.contextmanager
def flight_server(self):
cmd = ['java', '-cp', self.ARROW_FLIGHT_JAR,
self.ARROW_FLIGHT_SERVER,
'-port', str(self.FLIGHT_PORT)]
cmd = ['java'] + self.JAVA_OPTS + \
['-cp', self.ARROW_FLIGHT_JAR, self.ARROW_FLIGHT_SERVER,
'-port', str(self.FLIGHT_PORT)]
if self.debug:
print(' '.join(cmd))
server = subprocess.Popen(cmd, stdout=subprocess.PIPE)
Expand Down