-
Notifications
You must be signed in to change notification settings - Fork 4.1k
GH-38704: [C++] Implement Azure FileSystem Move() via Azure DataLake Storage Gen 2 API #39904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
c16a9c1
azurefs_test.cc: Use pcg for random number generation
felipecrv f001b40
azurefs_test.cc: Use different APIs to create containers/filesystems …
felipecrv 2b3067c
azurefs_test.cc: Provide a shorter method name for path creation
felipecrv 9af370c
Add exception.ErrorCode to the Status message
felipecrv a0b4b6f
Add GetBlobClient() helper function
felipecrv 016bb39
Extract GetFileInfoOfPathWithinContainer()
felipecrv 94ee77f
Add AcquireBlobLease() and AcquireContainerLease()
felipecrv 8ea6b85
Add lease_id param to GetFileInfo(adlfs_client, ...)
felipecrv 86d88c2
Add optional lease_id parameter to DeleteDirOnFileSystem
felipecrv 22eded5
Introduce the LeaseGuard class
felipecrv 80414f1
Add implementation skeleton of FileSystem::Move() + Impl::RenameConta…
felipecrv 723d6af
Work around Azurite limitations and SDK/service bugs
felipecrv 03cd298
Add checks for single and multi-container move operations
felipecrv cd238ec
Implement CreateContainerFromPath (one of the Move() scenarios)
felipecrv a66e85a
Improve utilities for creating and asserting POSIX errors
felipecrv 35cbd4c
Implement MovePaths and a huge sets of tests for it
felipecrv b41356e
Add lease acquisition/release logs and MovePathsWithDataLakeAPI logs
felipecrv c19c574
Revert "Add lease acquisition/release logs and MovePathsWithDataLakeA…
felipecrv 005c5c4
Incorporate early feedback by kou
felipecrv 1955b31
Add comments after Matt Topol's feedback
felipecrv 0fb549b
io_util.h: Add missing include
felipecrv 86c551a
Remove calls to a method that doesn't exist
felipecrv 280a61c
Changes based on latest comments by kou
felipecrv 419d7df
Fix ASAN violation in NormalizerKeyValueMetadata (unrelated)
felipecrv 89a1ce2
Merge branch 'main' into azure_move
felipecrv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.