Skip to content

Remove some unsafe and allocations when creating PrimitiveArrays from Vec and from_trusted_len_iter #9299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 3 commits into from
Jan 30, 2026
+9 −10
Merged

Remove some unsafe and allocations when creating PrimitiveArrays from Vec and from_trusted_len_iter #9299

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cddbc4
Remove some unsafe and allocations when creating PrimitiveArrays
alamb Jan 29, 2026
9630e26
Merge remote-tracking branch 'apache/main' into alamb/faster_safer
alamb Jan 29, 2026
027d9e2
fmt
alamb Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions arrow-array/src/array/primitive_array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ use crate::timezone::Tz;
use crate::trusted_len::trusted_len_unzip;
use crate::types::*;
use crate::{Array, ArrayAccessor, ArrayRef, Scalar};
use arrow_buffer::{ArrowNativeType, Buffer, NullBuffer, NullBufferBuilder, ScalarBuffer, i256};
use arrow_buffer::{
ArrowNativeType, BooleanBuffer, Buffer, NullBuffer, NullBufferBuilder, ScalarBuffer, i256,
};
use arrow_data::bit_iterator::try_for_each_valid_idx;
use arrow_data::{ArrayData, ArrayDataBuilder};
use arrow_schema::{ArrowError, DataType};
Expand Down Expand Up @@ -1488,10 +1490,9 @@ impl<T: ArrowPrimitiveType> PrimitiveArray<T> {

let (null, buffer) = unsafe { trusted_len_unzip(iterator) };

let data = unsafe {
ArrayData::new_unchecked(T::DATA_TYPE, len, None, Some(null), 0, vec![buffer], vec![])
};
PrimitiveArray::from(data)
let nulls =
Some(NullBuffer::new(BooleanBuffer::new(null, 0, len))).filter(|n| n.null_count() > 0);
Copy link
Contributor Author

@alamb alamb Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the

  1. no more unsafe
  2. Use avoid vec![buffer] allocation

PrimitiveArray::new(ScalarBuffer::from(buffer), nulls)
}
}

Expand All @@ -1502,11 +1503,9 @@ macro_rules! def_numeric_from_vec {
( $ty:ident ) => {
impl From<Vec<<$ty as ArrowPrimitiveType>::Native>> for PrimitiveArray<$ty> {
fn from(data: Vec<<$ty as ArrowPrimitiveType>::Native>) -> Self {
let array_data = ArrayData::builder($ty::DATA_TYPE)
.len(data.len())
.add_buffer(Buffer::from_vec(data));
let array_data = unsafe { array_data.build_unchecked() };
PrimitiveArray::from(array_data)
let buffer = ScalarBuffer::from(Buffer::from_vec(data));
let nulls = None;
PrimitiveArray::new(buffer, nulls)
}
}

Expand Down
Loading