Improve PrimitiveArray::from_iter perf
#9294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
changed the title
PrimitiveArray::from_iterPrimitiveArray::from_iter perf
alamb
approved these changes
Jan 29, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks like a good improvement to me.
Contributor
Author
|
run benchmark arrow_statistics |
Contributor
Sorry I think the VM runner got rebooted / wasn't working. I restarted it and now the queue is good |
Contributor
|
show benchmark queue |
|
🤖 Hi @alamb, you asked to view the benchmark queue (#9294 (comment)).
|
|
🤖 |
|
🤖: Benchmark completed Details
|
Contributor
|
run benchmark arrow_statistics |
|
🤖 |
|
🤖: Benchmark completed Details
|
Contributor
|
Those are some pretty sweet results |
alamb
added a commit
that referenced
this pull request
Jan 30, 2026
…om Vec and `from_trusted_len_iter` (#9299) # Which issue does this PR close? - part of #9298 # Rationale for this change While reviewing #9294 from @Dandandan I noticed some other places where we can avoid making ArrayData and thus save some allocations (and `unsafe`) I don't expect this to make a huge performance difference, but every little allocation helps, and I think the change is justified simply from the perspective of avoiding some more `unsafe` # What changes are included in this PR? Construct primitive arrays directly # Are these changes tested? By existing CI # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Speeds up
from_iter.This speeds up creation for statistics if all values are present (common case):
What changes are included in this PR?