[minor] Name Magic Number "8" in FixedSizeBinaryArray::new_null
#8914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobixdev
changed the title
FixedSizeBinaryArray::new_null
alamb
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
It's non-obvious why the number "8" appears here.
What changes are included in this PR?
Name the number such that it's more obvious that this is a conversion from bytes to bits.
@alamb I can also include the suggested comment if you prefer it. I thought the constant may have a lesser risk of becoming outdated without being noticed when changes to
MutableBuffer::new_nullhappen.Are these changes tested?
Are there any user-facing changes?