-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Parquet] Add ParquetMetadataPushDecoder #8080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
dfd6435
ParquetMetaDataPushDecoder
alamb 8e0bc63
Merge remote-tracking branch 'apache/main' into alamb/push_metadata_d…
alamb 5fc55da
Update with new PageIndexPolicy API
alamb 3c292b2
Fix docs
alamb 8a9630a
Merge branch 'main' into alamb/push_metadata_decoder
alamb c972049
Merge remote-tracking branch 'apache/main' into alamb/push_metadata_d…
alamb 297fbfb
Add coalescing discussion
alamb 3f4ad09
break when found
alamb be330af
fmt
alamb e2ed491
Apply suggestions from code review
alamb a5e7834
Merge remote-tracking branch 'apache/main' into alamb/push_metadata_d…
alamb d04d3c5
Improve comments
alamb 060e27e
Merge branch 'main' into alamb/push_metadata_decoder
alamb d76b415
Merge remote-tracking branch 'apache/main' into alamb/push_metadata_d…
alamb 52b5343
Update parquet/src/file/metadata/push_decoder.rs
alamb 4e20f57
Merge branch 'alamb/push_metadata_decoder' of github.com:alamb/arrow-…
alamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the one part of this PR I am not sure about
Since the
ParquetErroris (now) marked as#[non_exhaustive]I don't think this is technically a breaking change. However, it would be really nice to avoid a new enum -- I will comment about this later in the PRThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I had this error in my original draft of
ParquetMetaDataReader(3c340b7) but got talked out of it 😅 (#6392 (comment))There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have known you were right and gone with your instinct!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I could remove
ParquetError::NeedMoreDataRangeif I reworked the decoder to have a proper state machine internally (rather than calling into the existingParquetMetaDataDecoder).That is certainly my long term plan. If we like this API I will invest some time into seeing if I can sketch out what it would look like