-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Optimize coalesce kernel for StringView (10-50% faster) #7650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
dd4e92c
Optimize coalesce kernel for StringViewArrays
alamb 6d3cf73
sketch API
alamb 63c6ffa
checkpoint
alamb 3d9c08d
checkpoint
alamb 5d3284b
checkpoint
alamb dfcc5ad
update
alamb 7aaeba5
cleanup
alamb 7f812d1
a bit of unsafe
alamb 1d4c13b
tweak
alamb 289ce49
tweak
alamb 61184c2
remove old code
alamb e9f18f2
Optimize by not inlining
alamb 6dd3aa7
fix test
alamb 7166892
Allocate on write
alamb eb6e123
comment
alamb 2aec095
Adjust buffer sizes
alamb 5aed0b8
Merge remote-tracking branch 'apache/main' into alamb/faster_coalesce
alamb 622171f
Clippy and docs
alamb 7e10eb0
Refactor and add code to use existing buffer
alamb 8d4fad5
clippy
alamb 78f12bc
Merge remote-tracking branch 'apache/main' into alamb/faster_coalesce
alamb 8302949
Avoid RecordBatch::slice
alamb d63cac7
Use new API for appending values to avoid slices
alamb 84a6394
better error
alamb e4c4743
Improve comments
alamb 860a968
more docs
alamb 39916b3
more docs
alamb 9916172
Merge remote-tracking branch 'apache/main' into alamb/faster_coalesce
alamb e67d031
fmt
alamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should set this as constant somewhere and use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea and I will do it in a follow on PR