Improve coalesce_kernel benchmark to capture inline vs non inline views #7619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 6, 2025
| } | ||
| .build(); | ||
|
|
||
| // Model mostly short strings, but some longer ones |
Contributor
Author
There was a problem hiding this comment.
Previously all the benchmarks used a max size of 30. Now I have 20 (12/20 = 60% will be inlined views) and 128 where only 12/128 ~ 1% will be inlined views.
alamb
changed the title
Dandandan
approved these changes
Jun 6, 2025
Contributor
Dandandan
left a comment
Dandandan
left a comment
There was a problem hiding this comment.
I think this is a nice extension :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
coalescekernel andBatchCoalescerfor statefully combining selected b…atches: #7597Rationale for this change
While reviewing the code and the concat kernel for
StringViewArray#7617I realized there is a non trivial difference when there all inlined views vs some inlined views vs mostly large strings so the benchmarks should capture that
What changes are included in this PR?
Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.