Fix validation logic in StructArray::try_new to account for array.logical_nulls() returning Some() and null_count == 0
#7436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2025
alamb
approved these changes
May 8, 2025
Contributor
There was a problem hiding this comment.
Thank you @phillipleblanc -- this PR looks good to me
As I am trying to prepare for a release tomorrow, could you possibly look at the suggestions? I think they are both worth doing prior to merge. Sorry for the delay in reviewing
Contributor
Author
|
Thanks for taking a look @alamb - this is ready for another review. |
Contributor
Author
|
Hmm, I'm not sure why the integration test failed - I'll try re-running? |
Contributor
|
Thanks @phillipleblanc |
Member
|
Just faced this, thank you for fixing |
phillipleblanc
deleted the
phillip/250423-upstream-struct-array-validation-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
logical_nulls()returns Some() && null_count == 0 #7435Rationale for this change
Fixes the validation logic in StructArray::try_new to not error if there aren't any unmasked nulls, but
a.logical_nulls()returns SomeWhat changes are included in this PR?
A single line change to check for
null_count()on theNullBufferbefore comparing against the parent nulls.Are there any user-facing changes?
No