Skip to content

Remove "NOT YET FULLY SUPPORTED" comment from DataType::Utf8View/BinaryView #6380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Sep 17, 2024
Merged

Remove "NOT YET FULLY SUPPORTED" comment from DataType::Utf8View/BinaryView #6380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions arrow-schema/src/datatype.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,7 @@ pub enum DataType {
/// A single LargeBinary array can store up to [`i64::MAX`] bytes
/// of binary data in total.
LargeBinary,
/// (NOT YET FULLY SUPPORTED) Opaque binary data of variable length.
///
/// Note this data type is not yet fully supported. Using it with arrow APIs may result in `panic`s.
/// Opaque binary data of variable length.
///
/// Logically the same as [`Self::Binary`], but the internal representation uses a view
/// struct that contains the string length and either the string's entire data
Expand All @@ -280,9 +278,7 @@ pub enum DataType {
/// A single LargeUtf8 array can store up to [`i64::MAX`] bytes
/// of string data in total.
LargeUtf8,
/// (NOT YET FULLY SUPPORTED) A variable-length string in Unicode with UTF-8 encoding
///
/// Note this data type is not yet fully supported. Using it with arrow APIs may result in `panic`s.
/// A variable-length string in Unicode with UTF-8 encoding
///
/// Logically the same as [`Self::Utf8`], but the internal representation uses a view
/// struct that contains the string length and either the string's entire data
Expand Down