return reference from DictionaryArray::values() (#313) #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
approved these changes
May 17, 2021
Member
jorgecarleitao
left a comment
jorgecarleitao
left a comment
There was a problem hiding this comment.
LGTM. Yeap, fully agree 👍
Signed-off-by: Raphael Taylor-Davies <[email protected]>
tustvold
force-pushed
the
dictionary-values-reference
branch
from
d5cffcd to
6217913
Compare
Contributor
Author
|
@jorgecarleitao Rebased to fix accidental formatting change, you were faster than anticipated :D |
Contributor
|
This is probably technically a "breaking" change as some code that used to compile will no longer... |
alamb
approved these changes
May 17, 2021
Contributor
|
Nice! While we're looking at the DictionaryArray and introducing api changes, we should also remove the |
alamb
pushed a commit
to alamb/arrow-rs
that referenced
this pull request
May 22, 2021
) Signed-off-by: Raphael Taylor-Davies <[email protected]>
This was referenced May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #313.
Rationale for this change
See ticket, but in short it allows borrow lifetimes to correctly propagate without creating issues around stack-local temporaries
Are there any user-facing changes?
As currently formulated this is a breaking change, but it could easily be reworked to not be if preferred.
EDIT: I don't seem to have permission to add the breaking change label as instructed by the placeholder text