Remove parquet dictionary converters (#1661) #1662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
approved these changes
May 6, 2022
Contributor
|
@tustvold can you confirm that this is (technically) an API change (as in it would be possible for someone to have code that relied on the |
Contributor
Author
|
No, this module is marked experimental so should be fine See https://github.com/apache/arrow-rs/blob/master/parquet/src/arrow/mod.rs#L126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1161
Following #1180 these are no longer used
Rationale for this change
Code cleanup
What changes are included in this PR?
Removes some orphaned code
Are there any user-facing changes?
No, the converter module is marked experimental