implement eq_dyn, neq_dyn, lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn for timestamp types #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1095 +/- ##
==========================================
+ Coverage 82.31% 82.32% +0.01%
==========================================
Files 168 168
Lines 49420 49436 +16
==========================================
+ Hits 40679 40700 +21
+ Misses 8741 8736 -5
Continue to review full report at Codecov.
|
jimexist
approved these changes
Dec 25, 2021
Member
Author
|
Thanks for review. Is this ready to go? |
alamb
approved these changes
Dec 29, 2021
| /// `A_VEC` and `B_VEC` can be of type `Vec<i64>` or `Vec<Option<i64>>`. | ||
| /// `EXPECTED` can be either `Vec<bool>` or `Vec<Option<bool>>`. | ||
| /// The main reason for this macro is that inputs and outputs align nicely after `cargo fmt`. | ||
| macro_rules! cmp_i64 { |
Member
Author
|
Thanks @alamb @jimexist @liukun4515 ! |
This was referenced Jan 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1086.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?