GH-23: Add PR template #164
Conversation
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
We need Fixes #XXX in PR description because we don't use a merge script.
.github/pull_request_template.md
Outdated
| @@ -0,0 +1,60 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
How about using raw text instead of comment text?
It seems that most developers don't remove comment in pull request template.
In apache/arrow, we remove comments in our merge script https://github.com/apache/arrow/blob/0c3206772051c52fe2e648623daaca2c4e71cb72/dev/merge_arrow_pr.py#L603-L604 but we don't use merge script in apache/arrow-go. So our commit history have many this comments...
If we use raw text instead of comment text, we can notice it before we use the merge button. We can remove needless texts before we merge.
|
@kou how about a simple template with just the headings? I think we can give enough faith in developers to understand the sections without worrying about them having to remember to delete sample text? |
2 participants
Fixes #23