feat: add error log skywalking reporter #4633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
reviewed
Jul 20, 2021
tokers
reviewed
Jul 22, 2021
spacewander
reviewed
Jul 22, 2021
|
If these changes are ok in basically, I will update the related docs and tests. |
tokers
reviewed
Jul 23, 2021
starsz
reviewed
Jul 23, 2021
|
@dmsolr Please also replenish the documents. |
spacewander
reviewed
Jul 26, 2021
spacewander
reviewed
Jul 27, 2021
tokers
reviewed
Jul 28, 2021
| === TEST 5: log an warn level message |
There was a problem hiding this comment.
What information did I miss? What's the point of these tests.
There was a problem hiding this comment.
This case is testing whether a warning message could be wrapper as the skywalking log format
spacewander
reviewed
Jul 28, 2021
spacewander
reviewed
Aug 3, 2021
t/plugin/error-log-logger.t
Outdated
| === TEST 9: want to reload the plugin by route | ||
| === TEST 9: log a warn level message (schema compatibility testing) |
There was a problem hiding this comment.
Better to add test at the end of file
There was a problem hiding this comment.
we have resetting environment tasks at the end.
| | tcp.port | integer | required | | [0,...] | Target upstream port. | | ||
| | tcp.tls | boolean | optional | false | | Control whether to perform SSL verification. | | ||
| | tcp.tls_server_name | string | optional | | | The server name for the new TLS extension SNI. | | ||
| | skywalking.endpoint_addr | string | required | http://127.0.0.1:12900/v3/logs | | the http endpoint of Skywalking. | |
There was a problem hiding this comment.
Once you provide a default value it is no longer required.
spacewander
approved these changes
Aug 3, 2021
tokers
reviewed
Aug 3, 2021
tokers
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Pre-submission checklist:
his plugin is
error-log-logger-like, but it sends log data to Apache SkyWalking over http.