Skip to content

Conversation

@joshdcu
Copy link

@joshdcu joshdcu commented Oct 28, 2025

Description

Preserve ETag and Last-Modified headers in Brotli-compressed response.

Which issue(s) this PR fixes:

Fixes #12707

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Oct 28, 2025
@joshdcu joshdcu changed the title Preserve ETag and Last-Modified headers in Brotli-compressed response fix(brotli): Preserve ETag and Last-Modified headers in Brotli-compressed response Oct 28, 2025
@Baoyuantop
Copy link
Contributor

Hi @yuweizzz, could you please confirm this change?

@yuweizzz
Copy link
Contributor

It is ok to preserve those headers, but for the etag header, if it exists, you need to transfer it to weak etag.

and add a test case.

@Baoyuantop
Copy link
Contributor

It is ok to preserve those headers, but for the etag header, if it exists, you need to transfer it to weak etag.

and add a test case.

Hi @joshdcu, can you make further modifications?

@joshdcu
Copy link
Author

joshdcu commented Nov 3, 2025

Yes, will be working on it soon, thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ETag and Last-Modified headers are not preserved when response is Brotli-compressed

3 participants