Skip to content

fix(leader-election): exit after Leader status is lost #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(leader-election): exit after Leader status is lost #2236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d513e59
fix(leader-election): exit after Leader status is lost
Ben10k May 15, 2024
bbda1fa
fix(leader-election): cancel context when c.run() returns
Ben10k May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/providers/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,9 @@ func (c *Controller) Run(ctx context.Context) error {

c.run(rootCtx)

// c.run should never be returning when there's no error or the context is cancelled
rootCancel()

wg.Wait()
return nil
}
Expand Down Expand Up @@ -231,6 +234,9 @@ func (c *Controller) setupLeaderElection() error {
zap.String("namespace", c.namespace),
zap.String("pod", c.name),
)
// rootCancel might be to slow, and controllers may have bugs that cause them to not yield
// the safest way to step down is to simply cause a pod restart
os.Exit(0)
},
},
ReleaseOnCancel: true,
Expand Down