Fix connection access in triggerer for deferrable operators #57154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
force-pushed
the
fix-conn-async
branch
2 times, most recently
from
7f160e0 to
42a30d7
Compare
amoghrajesh
reviewed
Oct 23, 2025
task-sdk/src/airflow/sdk/execution_time/secrets/execution_api.py
Outdated
Show resolved
Hide resolved
When deferrable operators run in the triggerer's async event loop and synchronously access connections (e.g., via @cached_property), the `ExecutionAPISecretsBackend` failed silently. This occurred because `SUPERVISOR_COMMS.send()` uses `async_to_sync`, which raises `RuntimeError` when called within an existing event loop in a greenback portal context. Add specific RuntimeError handling in `ExecutionAPISecretsBackend` that detects this scenario and uses `greenback.await_()` to call the async versions (aget_connection/aget_variable) as a fallback. It was originally fixed in apache#55799 for 3.1.0 but apache#56602 introduced a bug. Ideally all providers handle this better and have better written Triggers. Example PR for Databricks: apache#55568 Fixes apache#57145
amoghrajesh
approved these changes
Oct 23, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
The job works as I would expect it to now!
If connection exists:
If it doesn't:
For a non databricks deferred job:
http = HttpOperator(
task_id="test_HTTP_op",
http_conn_id="http_default",
endpoint="get",
method="GET",
deferrable=True,
response_check=lambda response: response.status_code == 200,
log_response=True,
)
kaxil
added a commit
that referenced
this pull request
Oct 23, 2025
When deferrable operators run in the triggerer's async event loop and synchronously access connections (e.g., via @cached_property), the `ExecutionAPISecretsBackend` failed silently. This occurred because `SUPERVISOR_COMMS.send()` uses `async_to_sync`, which raises `RuntimeError` when called within an existing event loop in a greenback portal context. Add specific RuntimeError handling in `ExecutionAPISecretsBackend` that detects this scenario and uses `greenback.await_()` to call the async versions (aget_connection/aget_variable) as a fallback. It was originally fixed in #55799 for 3.1.0 but #56602 introduced a bug. Ideally all providers handle this better and have better written Triggers. Example PR for Databricks: #55568 Fixes #57145 (cherry picked from commit da32b68)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deferrable operators run in the triggerer's async event loop and synchronously access connections (e.g., via @cached_property), the
ExecutionAPISecretsBackendfailed silently. This occurred becauseSUPERVISOR_COMMS.send()usesasync_to_sync, which raisesRuntimeErrorwhen called within an existing event loop in a greenback portal context.Add specific RuntimeError handling in
ExecutionAPISecretsBackendthat detects this scenario and usesgreenback.await_()to call the async versions (aget_connection/aget_variable) as a fallback.It was originally fixed in #55799 for 3.1.0 but #56602 introduced a bug.
Ideally all providers handle this better and have better written Triggers. Example PR for Databricks: #55568
Fixes #57145
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.