Skip to content

Restore timtable active_runs_limit check #56922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

Restore timtable active_runs_limit check #56922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions task-sdk/src/airflow/sdk/definitions/dag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,13 @@ def __attrs_post_init__(self):
RemovedInAirflow4Warning,
stacklevel=2,
)
if (
active_runs_limit := self.timetable.active_runs_limit
) is not None and active_runs_limit < self.max_active_runs:
raise ValueError(
f"Invalid max_active_runs: {type(self.timetable)} "
f"requires max_active_runs <= {active_runs_limit}"
)

@params.validator
def _validate_params(self, _, params: ParamsDict):
Expand Down
15 changes: 15 additions & 0 deletions task-sdk/tests/task_sdk/definitions/test_dag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,21 @@ def test_create_dag_while_active_context():
# No asserts needed, it just needs to not fail


@pytest.mark.parametrize("max_active_runs", [0, 1])
def test_continuous_schedule_interval_limits_max_active_runs(max_active_runs):
from airflow.timetables.simple import ContinuousTimetable

dag = DAG(dag_id="continuous", schedule="@continuous", max_active_runs=max_active_runs)
assert isinstance(dag.timetable, ContinuousTimetable)
assert dag.max_active_runs == max_active_runs


def test_continuous_schedule_interval_limits_max_active_runs_error():
with pytest.raises(ValueError) as ctx:
DAG(dag_id="continuous", schedule="@continuous", max_active_runs=2)
assert str(ctx.value) == "Invalid max_active_runs: ContinuousTimetable requires max_active_runs <= 1"


class TestDagDecorator:
DEFAULT_ARGS = {
"owner": "test",
Expand Down