[v3-1-test] Fix DAG processor crash with pre-import module optimization (#56773) #56779
+14
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Oct 17, 2025
…on (#56773) The DAG processor would crash when parsing_pre_import_modules=True and a DAG imported a provider with missing optional dependencies. This occurred because providers raise `AirflowOptionalProviderFeatureException` for missing dependencies, but the pre-import code only caught `ModuleNotFoundError`. This was a regression from Airflow 2.x where the original implementation correctly caught all exceptions. The pre-import optimization is non-critical and should never crash the DAG processor - any import errors are properly handled later during actual DAG parsing. Fixes #56755 (cherry picked from commit 9ef4f12) Co-authored-by: Kaxil Naik <[email protected]>
potiuk
force-pushed
the
backport-9ef4f12-v3-1-test
branch
from
2d87b8a to
20008cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DAG processor would crash when parsing_pre_import_modules=True and
a DAG imported a provider with missing optional dependencies. This occurred
because providers raise
AirflowOptionalProviderFeatureExceptionfor missingdependencies, but the pre-import code only caught
ModuleNotFoundError.This was a regression from Airflow 2.x where the original implementation
correctly caught all exceptions. The pre-import optimization is non-critical
and should never crash the DAG processor - any import errors are properly
handled later during actual DAG parsing.
Fixes #56755
(cherry picked from commit 9ef4f12)
Co-authored-by: Kaxil Naik [email protected]