Fix: Correctly parse JSON for --dag_run_conf in airflow dags backfill CLI #56380
+86
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add import json and update the argument parsing in create_backfill.
HsiuChuanHsu
force-pushed
the
fix/cli-backfill-dag-conf-json-parsing
branch
from
b0b9fc6 to
bd03243
Compare
hussein-awala
approved these changes
Oct 4, 2025
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
Looks good, LGTM
Note: It is not possible to run the unit tests (even existing ones) successfully in the IDE, because the local user is not "root", we may need to fix them later.
potiuk
approved these changes
Oct 13, 2025
potiuk
added
the
backport-to-v3-1-test
github-actions bot
pushed a commit
that referenced
this pull request
Oct 13, 2025
…ags backfill CLI (#56380) * feat: Parse and validate JSON for --dag-run-conf in backfill command Add import json and update the argument parsing in create_backfill. * unit tests covering valid JSON, invalid JSON, and empty JSON cases (cherry picked from commit 6bcf3e8) Co-authored-by: Gary Hsu <[email protected]>
Backport successfully created: v3-1-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 13, 2025
…ags backfill CLI (apache#56380) * feat: Parse and validate JSON for --dag-run-conf in backfill command Add import json and update the argument parsing in create_backfill. * unit tests covering valid JSON, invalid JSON, and empty JSON cases (cherry picked from commit 6bcf3e8) Co-authored-by: Gary Hsu <[email protected]>
Contributor
Author
|
Thanks for the review! 🤩 |
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
… CLI (apache#56380) * feat: Parse and validate JSON for --dag-run-conf in backfill command Add import json and update the argument parsing in create_backfill. * unit tests covering valid JSON, invalid JSON, and empty JSON cases
potiuk
pushed a commit
that referenced
this pull request
Oct 14, 2025
…ags backfill CLI (#56380) (#56599) * feat: Parse and validate JSON for --dag-run-conf in backfill command Add import json and update the argument parsing in create_backfill. * unit tests covering valid JSON, invalid JSON, and empty JSON cases (cherry picked from commit 6bcf3e8) Co-authored-by: Gary Hsu <[email protected]>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
… CLI (apache#56380) * feat: Parse and validate JSON for --dag-run-conf in backfill command Add import json and update the argument parsing in create_backfill. * unit tests covering valid JSON, invalid JSON, and empty JSON cases
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
… CLI (apache#56380) * feat: Parse and validate JSON for --dag-run-conf in backfill command Add import json and update the argument parsing in create_backfill. * unit tests covering valid JSON, invalid JSON, and empty JSON cases
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
… CLI (apache#56380) * feat: Parse and validate JSON for --dag-run-conf in backfill command Add import json and update the argument parsing in create_backfill. * unit tests covering valid JSON, invalid JSON, and empty JSON cases
TyrellHaywood
pushed a commit
to TyrellHaywood/airflow
that referenced
this pull request
Oct 22, 2025
… CLI (apache#56380) * feat: Parse and validate JSON for --dag-run-conf in backfill command Add import json and update the argument parsing in create_backfill. * unit tests covering valid JSON, invalid JSON, and empty JSON cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The configuration passed to the
airflow dags backfillcommand using the --dag_run_conf argument was not being correctly parsed as a JSON string.Changes
dag_run_conffrom JSON string to dict when providedClose: #56230
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.